dangernoodle-io / breadboard / 30416590244

97%

push

github

refactor!: fold bb_prov_default_form into bb_wifi_prov (#1124)

bb_prov_default_form was never an approved component -- it was
grandfathered into the new_component fence baseline when that gate was
introduced (#792), having actually been created by PR #51, ~740 PRs
earlier. The default provisioning form stays as a built-in default, but
now lives inside bb_wifi_prov instead of its own component (effectively
a revert of #51).

BREAKING: bb_prov_default_form_get() / bb_prov_default_form.h are gone.
Consumers move to bb_wifi_prov_default_form_get() /
bb_wifi_prov_default_form.h.

- moved prov_default_form.html + the getter TU into
  components/bb_wifi_prov/default_form/ (own subdir, not src/ or the
  component root -- boards.py's derive_component() globs *.c
  non-recursively under src/ and the component root for the host/native
  scaffold build, and bb_wifi_prov is in [capability.core], so a
  same-directory placement would've pulled the getter's TU into every
  host test build too, where the generated gz blob doesn't exist)
- deleted components/bb_prov_default_form/ entirely
- bb_wifi_prov never references the getter internally -- consumers call
  it at their composition root, exactly as examples/floor does
- pruned bb_prov_default_form from
  .baseline/bbtool/fence/new_component.json (shrink, not a blessing)
- added lint rule prov-default-form-internal-ref: fails if anything
  inside bb_wifi_prov references the getter or gz symbol outside the
  form's own TU -- the tripwire against B1-966 (auto-registering the
  form via runtime route precedence), which would require exactly that
  internal reference
- updated bbtool.toml's floor manifest, bbtool touchpoints
  (cmake_parse.py, lint.py, their tests), and regenerated
  components/README.md + bb_wifi_prov/README.md

AC3 measurement (on unmodified origin/main, before this refactor):
building examples/floor with its existing bb_prov_default_form_get()
call present, then rebuilding with that call removed (nm... (continued)

7890 of 8494 branches covered (92.89%)

Branch coverage included in aggregate %.

13411 of 13566 relevant lines covered (98.86%)

2617.35 hits per line