dangernoodle-io / breadboard / 30415745390

97%

push

github

fix: propagate genuine /api/* route registration failures (#1123)

bb_http_register_route() always returned BB_OK for an /api/* path
regardless of what bb_dispatch_api_add() reported, so a dispatch-table
overflow (BB_ERR_NO_SPACE) silently dropped the route with no way for
the caller to detect it. Both the espidf and host backends now
propagate a genuine failure while still swallowing the
BB_ERR_INVALID_STATE duplicate-registration case to BB_OK -- that case
is deliberately tolerated (first-registration-wins, e.g. bb_wifi_prov
and bb_wifi_http both registering POST /api/wifi/scan) and must not
become a hard error for callers that don't special-case it.

Also fixes a latent test-order dependency in
test_register_described_route_overflow_returns_no_space: it now
actually depends on the shared dispatch table's real occupancy (the
old swallow-to-BB_OK masked this), so it resets the table before its
64-registration loop.

Ref B1-1253.


Claude-Session: https://claude.ai/code/session_01KM3KoyubaoM6eoUAsw8GYr

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

7890 of 8494 branches covered (92.89%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

13411 of 13566 relevant lines covered (98.86%)

2614.97 hits per line