valkyrjaio / valkyrja-java / 30416624840

100%

push

github

[CI] Bring the JUnit tests under ErrorProne, SpotBugs, and ArchUnit (#66)

# Description

Finishes aligning the Java test tree with the other ports, and closes
the static-analysis gap that
left the JUnit tests unchecked. Follows on from #63, which moved the
tree under `io.valkyrja.tests`.

**Fixture naming.** 58 of the 59 fixtures were still named `*Class` or
carried a bare type suffix.
The reference implementation's rule (`ci-phparkitect-php`, `Rules.php`)
suffixes everything under
`Fixtures\` with `*Fixture`, exempting only enums, traits, and
interfaces — PHP is 176/176 conforming
and TypeScript 23/23. Java had none of those exempt shapes, so all 58
were renamed. Type suffixes are
kept and `Fixture` appended, matching PHP's own
`RouteMatchedMiddlewareFixture`; generic `*Class`
names have `Class` replaced. This closes the cross-language migration
PHP and TypeScript completed on
2026-07-17, where Java was the last holdout.

Two needed judgment. `FixtureRouteHandler` became `RouteHandlerFixture`
— the rule is about the
suffix, and prefixing was never the convention.
`AbstractReflectableClass` collided: the taxonomy
says an abstract class must not repeat `Abstract` in its name, but the
obvious `ReflectableFixture`
is already taken by its concrete sibling, and `ReflectionTest` imports
both. It follows PHP's
`Auth/Authenticator/Abstract/AuthenticatorFixture` shape instead — moved
to a `reflection.abstract_`
segment and named for what it proves, `NonInstantiableFixture`.

**Static analysis.** The tests were compiled by the JUnit build and by
nothing else: the ErrorProne,
SpotBugs, and ArchUnit builds each pointed only at `src`, and their own
test source sets were empty
— which is why CI logged `spotbugsTest NO-SOURCE`. Their `files:`
filters had the matching hole, so a
test-only change skipped all three jobs. Spotless was the fourth and was
fixed in #58; this widens
the rest the same way. Java has no type-checking gap — `javac` compiles
the tests as a prec... (continued)

1912 of 1914 branches covered (99.9%)

Branch coverage included in aggregate %.

6962 of 6962 relevant lines covered (100.0%)

4.34 hits per line