valkyrjaio / valkyrja-java / 30416278714

100%

push

github

[Tests] Move the test tree under the tests namespace to match the other ports (#63)

# Description

Aligns the Java test tree with the other ports by moving it under a
`tests` namespace segment.

PHP (the reference implementation) uses
`Valkyrja\Tests\{Unit,Functional,Fixtures}` and TypeScript
mirrors it with `tests/Tests/{Unit,Functional,Fixtures}`. Java was the
only port without the
segment, placing its tests at `io.valkyrja.{unit,functional,fixtures}` —
siblings of the real
framework packages. Go is the intended exception going forward, since Go
tests must live in the
package they test.

The segment matters more in Java than elsewhere. In TypeScript `Tests/`
is just a directory, but a
Java package is a global identifier:
`io.valkyrja.fixtures.http.routing.PlainHttpController` is
indistinguishable by name from a framework package sitting beside
`io.valkyrja.http` and
`io.valkyrja.container`. `io.valkyrja.tests.fixtures.…` is
self-describing.

**The 15 package-private-access tests deliberately stay put.**
`ContainerTest`,
`UploadedFileInternalsTest`, `HeaderFactoryInternalsTest` and 12 others
live in
`io.valkyrja.<component>.…` because they need package-private access to
the class under test — a
placement the Java agent guide explicitly sanctions. PHP has no
package-private concept, so parity
here is inherently partial.

**A dead six-file stub is removed as part of the move.**
`io.valkyrja.tests.fixtures.container` has
existed since the very first test commit (#24), which created both it
*and* the top-level
`io/valkyrja/unit` layout. The top-level layout won immediately and took
all 500+ files; the stub
never grew past six and was skipped by #32 when `classes/` was renamed
to `fixtures/`. Nothing
outside those six files ever referenced the package, and each was
byte-identical to a live twin
under `io.valkyrja.fixtures.container`. Because the stub already sat at
exactly this move's
destination path with the correct package declaration, git resolves it... (continued)

1912 of 1914 branches covered (99.9%)

Branch coverage included in aggregate %.

6962 of 6962 relevant lines covered (100.0%)

4.34 hits per line