valkyrjaio / valkyrja-php / 30416416065

100%

push

github

[Cli] Add an overridable exit seam to Exiter (#947)

# Description

`Exiter::exit()` is `static::$exit ? exit($code) :
static::frozenCallback($code)`.
Every test has to call `Exiter::freeze()` first, because the unfrozen
arm calls
`exit()` and would terminate the PHPUnit process — so that arm was never
executed and its branch could not be covered by any test.

The remedy is the seam pattern already used for irreducible native calls
elsewhere in the framework (the entry workers,
`ResponseSendRecorderFixture`):
the bare `exit($code)` moves into its own overridable
`protected static exitCallback()` marked `@codeCoverageIgnore` — that
one
statement is genuinely untestable — and `exit()` now dispatches to it
through
`static::`. A `Tests\Fixtures` subclass overrides the seam to record the
code it
was called with, so the unfrozen arm of the ternary runs under test
while the
process survives.

Behavior is unchanged: unfrozen still exits with the given code, frozen
still
echoes it via `frozenCallback()`.

While adding the tests I also fixed `ExiterTest::testExitCode`, which
reassigned
`$code` from `ob_get_clean()` and then asserted `assertSame((string)
$code, $code)`
— comparing the captured output with itself, so it always passed
regardless of
what `Exiter` echoed. It now captures the output in `$output` and
asserts it
against the exit code.

Verified per-shard (never merged — Xdebug builds a different branch map
for a
function depending on whether it ran, so merged shard data invents
branches):

```
composer phpunit-path-coverage-shard Cli
```

**`src/Valkyrja/Cli/Server/Support/Exiter.php`: branches 5/6 → 7/7,
paths
4/5 → 5/5.** Line coverage stays at 100% — the seam body is excluded via
`@codeCoverageIgnore`.

## Types of changes

- [x] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which... (continued)

1 of 0 new or added lines in 0 files covered. (NaN%)

12595 of 12595 relevant lines covered (100.0%)

23.76 hits per line