valkyrjaio / valkyrja-php / 30415926697

100%

push

github

[Http] Add an overridable SAPI seam to UploadedFileFactory (#946)

# Description

`UploadedFileFactory::isValidSapiEnvironmentForUploads()` reads
`PHP_SAPI` and
returns `! str_starts_with($sapi, 'cli') && ! str_starts_with($sapi,
'phpdbg')`.
Under PHPUnit `PHP_SAPI` is always `cli`, so the first operand is always
false
and the second operand is never evaluated — one branch of that condition
is
unreachable by any test, and `PHP_SAPI` cannot be changed at runtime.

The remedy is the seam pattern already used for irreducible native calls
elsewhere in the framework (see `ResponseSendRecorderFixture` and the
entry
workers): the SAPI lookup moves into a small overridable
`protected static function getSapi()`, called through `static::` so a
subclass
can drive it. A `Tests\Fixtures` subclass overrides it to report `cli`,
`cli-server`, `phpdbg`, `apache2handler` and `fpm-fcgi`, which exercises
both
operands and both outcomes; the pre-existing real-call test
(`testIsValidSapiEnvironmentForUploadsReturnsFalseUnderCli`) still runs
the seam
body itself, so the `PHP_SAPI` read is covered too.

Public behavior is unchanged:
`UploadedFileFactory::isValidSapiEnvironmentForUploads()`
still resolves `getSapi()` to the real `PHP_SAPI`.

Verified per-shard (never merged — Xdebug builds a different branch map
for a
function depending on whether it ran, so merged shard data invents
branches):

```
composer phpunit-path-coverage-shard Http
```

**`src/Valkyrja/Http/Message/File/Factory/UploadedFileFactory.php`:
branches
25/26 → 27/27, paths 10/18 → 12/19.** (The denominator grows because the
seam
adds a method.)

## Types of changes

- [x] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- ... (continued)

3 of 0 new or added lines in 0 files covered. (NaN%)

12595 of 12595 relevant lines covered (100.0%)

23.76 hits per line