dangernoodle-io / breadboard / 30409250719

97%

push

github

feat: wire the stored hostname into bb_mdns at floor's composition root (B1-809) (#1116)

bb_mdns never read the stored hostname -- s_mdns_hostname defaulted to
the literal "bsp-device" and bb_mdns_set_hostname() had no caller, so
the wifi_prov hostname field landed cosmetic without this.

Wires bb_settings_hostname_get() -> bb_mdns_set_hostname() in
examples/floor/main/floor_app.c, immediately before bb_mdns_init()
(mdns_init_impl() reads the injected hostname exactly once, at that
first idempotent bb_once call). Placed in the consumer/composition
root rather than inside bb_mdns itself: bb_mdns is a primitive with no
bb_settings dependency today, and this repo's composition-only model
(CLAUDE.md) puts wiring in the consumer via codegen/handwire, not
inside the component being wired. Falls back to bb_mdns's own
MAC-derived default whenever the stored hostname is unset/empty.

Also corrects bb_mdns_set_hostname()'s stale header doc, which claimed
the opposite call order.


Claude-Session: https://claude.ai/code/session_01KM3KoyubaoM6eoUAsw8GYr

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

7852 of 8455 branches covered (92.87%)

Branch coverage included in aggregate %.

13367 of 13522 relevant lines covered (98.85%)

2614.22 hits per line