valkyrjaio / sindri-java / 30375967437

100%

push

github

[Sindri] Merge a provider's own publishers after the ones it nests (#55)

# Description

Generated `AppContainerData` mapped a service to the **framework's**
publisher when both the
application and the framework publish it, silently discarding the
application's own
generated data.

The starter application hit this the moment the framework began
publishing
`HttpRoutingDataContract` (valkyrjaio/valkyrja-java#52). Sindri emitted:

```java
Map.entry(HttpRoutingDataContract.class, HttpRoutingServiceProvider::publishData)
```

instead of the application's
`DataServiceProvider::publishHttpRoutingData`. At runtime the
framework publisher then re-collected the routes through the attribute
collector rather
than loading the generated cache — and because that collector builds a
controller with its
no-argument constructor, every request to a controller with dependencies
returned a 500.

PHP does not have this problem, and the difference is **ordering**, not
merge semantics —
both merge last-wins (PHP spreads, Java `putAll`). PHP's `walkProvider`
recurses into the
providers a provider nests **first** and merges that provider's own data
**last**:

```php
foreach ($providerResult->componentProviders as $subProvider) {
    $aggregated = $aggregated->merge($this->walkProvider($subProvider, $config, $visited));
}

return $aggregated->merge($providerResult);
```

Java walked the graph breadth-first, merging each provider's own service
providers **before**
queuing the ones it nests, so the framework's providers merged last and
won — exactly
backwards. PHP's generated `AppContainerData` proves the intended
result: it maps
`HttpRoutingData::class` to the application's
`DataServiceProvider::publishHttpRoutingData`.

This ports PHP's walk. `collectProviderData` now delegates to a
depth-first `walkProvider`
that merges nested providers first and the provider's own data last,
keeping the visited-set
cycle guard. An application provider nests the framework's component
providers,... (continued)

526 of 527 branches covered (99.81%)

Branch coverage included in aggregate %.

15 of 15 new or added lines in 1 file covered. (100.0%)

1515 of 1515 relevant lines covered (100.0%)

4.39 hits per line