valkyrjaio / sindri-java / 30375524339

100%

push

github

[Http] Pin the framework-computed dynamic route regex in the golden and end-to-end tests (#54)

# Description

The generated data-cache tests never pinned the match regex a dynamic
route
compiles to, so a change to the framework's regex format could roll
through
Sindri silently.

`valkyrja-java` v26.4.0 changed `Regex.START` / `Regex.END` from the PHP
reference's PCRE framing (`/^` … `$/`) to Java-native anchors (`^` …
`$`), which
changes every regex Sindri writes into `AppHttpRoutingData`. The
dependency bump
to 26.4.0 (#53) passed CI regardless. The sibling TypeScript repo caught
the
equivalent change immediately, because its golden snapshot pins the
framework's
computed regex; the Java suite did not, for two reasons:

- `GoldenSnapshotTest` built its `/users/{id}` route with the short
`HttpRouteData` constructor, so the route carried no parameters and an
empty
  regex. `buildRegexesBody` skipped it and the committed golden pinned
  `regexes()` as `Map.of()` — the regex path was never generated at all.
- The one end-to-end check in `GenerateDataFromConfigCommandTest`
asserted the
fragment `(?<value>[a-zA-Z]+)`, which survives the delimiters on either
side
  of it changing.

Both now pin the regex in full. Sindri computes a dynamic route's regex
in
`HttpRouteAttributeReader` by running the real framework `Processor` (so
the
cached regex is always identical to what the framework would compute at
runtime), and the golden fixture now does the same rather than
hard-coding a
literal — a framework format change therefore fails the snapshot instead
of
quietly rewriting every generated cache.

Verified by temporarily restoring the old `/^…$/` expectation,
confirming the
end-to-end test fails on it, then restoring. `./gradlew ci` passes.
Tests only —
no `src/` change, so coverage is unaffected.

## Types of changes

- [x] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-... (continued)

524 of 525 branches covered (99.81%)

Branch coverage included in aggregate %.

1513 of 1513 relevant lines covered (100.0%)

4.38 hits per line