kobotoolbox / kpi / 30362429149

82%

master: 76%

push

github

feat(bulkProcessing): disable bulk option if no data DEV-2496 DEV-2499 (#7325)

### 📣 Summary

The `Transcribe selected audio files` and `Translate selected
transcriptions` options in the data table column menu are now greyed out
when none of the selected submissions has anything to work with.

### 💭 Notes

Changes here:

- `bulkProcessingUtils.ts`
- new `hasTranscribableAudio()` / `hasAnyTranscribableAudio()` — a
non-deleted attachment for the given question xpath
- new `hasTranslatableTranscript()` / `hasAnyTranslatableTranscript()` —
a transcript with an actual `value`.
- `alerts/alertEvaluators.ts`
- `evaluateNoSource()` now calls those shared helpers instead of doing
its own inline checks.
- `tableColumnSortDropdown.tsx`
- new `isBulkTranscriptionDisabled` and `isBulkTranslationDisabled`
props, added into each item's existing `disabled` condition.
- `table.tsx`
- extracted `getSelectedSubmissions()` (the column header needs the
selected rows now, not just the modal opener) and passes both new props
per column.
- `bulkProcessingUtils.tests.ts`
- unit tests for all four helpers, including the deleted-attachment and
pending-review cases.

### 👀 Preview steps

1. ℹ️ have an account and a project with an audio question,
transcription/translation enabled in admin
2. add `?ff_bulkProcessingEnabled=true` to the URL to turn on the bulk
processing feature flag
3. submit three responses: **A** and **B** with an audio recording, and
**C** with the audio question skipped
4. go to Project → Data → Table
5. tick the checkbox for **C** only, then open the column menu (the
caret in the header) of the audio question
6. 🔴 [on main] `Transcribe selected audio files` is clickable — click
through the modal and get told there are no eligible submissions at the
end
7. 🟢 [on PR] `Transcribe selected audio files` is greyed out
8. now tick **A** only and use `Transcribe selected audio files`, run
the job, and wait for the transcript column to appear — leave the new
transcr... (continued)

9551 of 12864 branches covered (74.25%)

30911 of 37708 relevant lines covered (81.97%)

5.51 hits per line