dunglas / mercure / 30342913285

89%

master: 93%

push

github

fix: announce a subscription only once it exists

dispatchSubscriptionUpdate(active: true) ran before transport.AddSubscriber,
so a failed registration published an arrival for a subscriber that never
connected and then took it back with a compensating active:false. Observers
of the subscriptions namespace saw a subscriber appear and vanish while
metrics.SubscriberConnected never ran.

Registering first also makes the pair symmetric with shutdown(), which
already removes the subscriber before announcing active:false.

Side effect worth noting: a subscriber authorized for the subscriptions
namespace now receives its own active:true, because it is in the subscriber
list by the time the event is dispatched. That closes a gap for the
documented "fetch a snapshot, then follow events" flow, where its own
subscription previously appeared in neither.

2 of 2 new or added lines in 1 file covered. (100.0%)

2564 of 2890 relevant lines covered (88.72%)

219.85 hits per line