dunglas / mercure / 30342629935

89%

master: 93%

push

github

fix(bolt): report "earliest" when the requested Last-Event-ID is missing (#1321)

* fix(bolt): report "earliest" when the requested Last-Event-ID is missing

While searching for the requested id, every authorized event it walks past
advances the response cursor. When the id is never found nothing is
replayed, yet the cursor still reported the newest authorized event in the
scanned window, telling the subscriber it was caught up to an event it
never received. Only a log line recorded the failure.

The protocol reserves "earliest" for a requested event that does not exist
or has been discarded, which is exactly this case, and it makes the
client's compare-and-refetch check work. It also covers giving up at
maxHistoryScan, where the cursor was an arbitrary event 10000 entries deep.

A found id is still echoed back: the subscriber has it, and it really is
the event preceding the first one replayed.

* fix(bolt): unblock the subscriber before logging the missing id

HistoryDispatched sends on a buffered channel the subscriber is parked
on, so it cannot write its response headers until the value arrives.

12 of 12 new or added lines in 1 file covered. (100.0%)

2562 of 2890 relevant lines covered (88.65%)

216.46 hits per line