wol-soft / php-json-schema-model-generator / 30326374406

99%

master: 99%

Pull #178

github

Remove dead code and its explanatory comment from BuilderClass.phptpl

The @throws block for a builder setter's validators is unreachable code, not
just a documented limitation: BuilderClassPostProcessor unconditionally
strips every validator from builder properties via
filterValidators(fn() => false), so property.getValidators() can never be
non-empty in this template. Removed the block entirely instead of keeping a
dead branch alive "for whenever that changes" - if validators are ever
un-stripped, the @throws line can be reintroduced then, informed by whatever
that change actually needs.

Also drops the description-block comment explaining the standalone-if
choice - the pattern is now used pervasively across every class-emitting
template and no longer needs a per-callsite justification.

199 of 201 new or added lines in 23 files covered. (99.0%)

7176 of 7268 relevant lines covered (98.73%)

573.82 hits per line