decentraland / signatures-server / 30313693906

92%

main: 92%

Build Type

Pull #487

github

Committed by LautaroPetaccio

Commit Message

fix: do not race an executed listing against an index cancellation on refresh

when the indexer reported a rental newer than the stored listing, the refresh queued the executed
update, and the index branch, which still looked at the status the listing had before the refresh,
could queue a cancellation for the same row. both ran through the same promise all, so the status
that survived was whichever write landed last and an executed rental could end up cancelled.

the index branch is skipped when a newer rental was reported, since the on chain rental is the
source of truth for that listing, and the cancellation is restricted to open listings like the
other ones, which also makes the outcome independent of the order the writes land in.

Pull Request Pull Request #487: fix: stop cancelling listings whose asset the rentals contract holds

Coverage Stats

350 of 377 branches covered (92.84%)

Branch coverage included in aggregate %.

63 of 65 new or added lines in 8 files covered. (96.92%)

2 existing lines in 1 file now uncovered.

685 of 751 relevant lines covered (91.21%)

48.31 hits per line