decentraland / signatures-server / 30313067898

92%

main: 92%

Build Type

Pull #487

github

Committed by LautaroPetaccio

Commit Message

fix: keep index cancellations to open listings and make them visible to updatedAfter

review findings on the three index bump statements.

they matched rows in any status, so a nonce bump could rewrite an executed or a claimed listing to
cancelled and lose the rental history of an asset. they also left updated_at untouched, so the
consumers that poll the listings incrementally, the atlas server among them, never saw the
cancellation. both are fixed by restricting the update to open listings and moving the timestamp.

the same statements compared addresses with raw equality, which misses the rows stored with a
checksummed casing before this branch started writing them canonically, and compared nonces as
text, which orders 9 after 10 and left listings open when the index crossed into two digits. the
comparisons now lower case the addresses and cast the nonces to numeric.

the reviewer pointed at the three index statements, and the same two problems were in the other
cancellation paths, so the refresh, the metadata job and the expiration sweep were given the same
treatment. the refresh could also rewrite an executed listing through its dissolved estate branch,
which had no status guard.

Pull Request Pull Request #487: fix: stop cancelling listings whose asset the rentals contract holds

Coverage Stats

349 of 376 branches covered (92.82%)

Branch coverage included in aggregate %.

61 of 63 new or added lines in 8 files covered. (96.83%)

2 existing lines in 1 file now uncovered.

685 of 751 relevant lines covered (91.21%)

47.86 hits per line