decentraland / signatures-server / 30311499338

92%

main: 92%

Build Type

Pull #487

github

Committed by LautaroPetaccio

Commit Message

fix: compare addresses ignoring casing and alias the misspelled signer field

review findings on the ownership checks and the index update query.

addresses reach the server from the authorization middleware, the request body, the indexers and
the contract definitions, and those sources do not agree on casing. the checks that decide whether
the lessor still controls an asset compared them with raw equality, so a listing whose rental
contract address was stored checksummed was read as not held by the rentals contract and cancelled
by the refresh, which is the very thing the previous commit set out to prevent. the comparisons now
ignore casing, and the address of the contract is stored instead of the one the caller sent, so new
rows are always written with the same casing. a test seeds a checksummed address and asserts the
listing survives a refresh.

the index update history query asked for singerUpdate, which is how the subgraph schema spells it,
while the type and the update job read signerUpdate. the key was therefore always missing and signer
index bumps never cancelled anything. the field is now aliased to the correct spelling. a stubbed
subgraph answers with whatever the spec gives it, so the query itself is asserted instead.

also validates that the id of the refresh endpoint is a uuid. it reaches a uuid column, so a
malformed one made postgres fail the request and answered a 500 on an unauthenticated route.

the unit spec mocked the whole logic module, which replaced the new pure helper with a stub that
returned undefined. only the two functions that reach outside are stubbed now.

Pull Request Pull Request #487: fix: stop cancelling listings whose asset the rentals contract holds

Coverage Stats

348 of 375 branches covered (92.8%)

Branch coverage included in aggregate %.

61 of 63 new or added lines in 8 files covered. (96.83%)

2 existing lines in 1 file now uncovered.

685 of 751 relevant lines covered (91.21%)

46.28 hits per line