ruby-grape / grape / 30305794628

97%

master: 97%

Pull #2834

github

Restore the per-attempt routing args in Grape::Router

#2824 made process_route build a fresh routing-args Hash per attempt, so
a candidate tried after a cascading match (X-Cascade pass) could not
observe the previous attempt's :route_info or path captures. #2829 was
squash-merged from a branch cut before #2824 landed, so its squashed diff
replayed the stale router.rb over the fix and dropped the regression spec
along with it. Git reported no conflict, and #2824's CHANGELOG entry
survived, so the tree claims a fix it no longer has.

Symptoms are back on master: with a cascading v2 and a serving v1, the
`route` helper returns v2's route (origin "/:id" instead of "/:name") and
v2's capture leaks into params as {"id"=>"123", "name"=>"123"} -- an
endpoint sees a param it never declared.

Restore the fix and its spec verbatim. The router is the only writer of
env['grape.routing_args'], so the unconditional assignment is safe.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

1195 of 1284 branches covered (93.07%)

Branch coverage included in aggregate %.

3791 of 3858 relevant lines covered (98.26%)

26845.36 hits per line