christophevg / yoker / 30302724987

87%

push

github

fix: address PR #53 feedback — make confirm_approval optional on UIHandler Protocol

Owner objected to the isinstance(ui, BatchUIHandler) special-case check.
Following the established agent_spawned/agent_finished optional pattern:
- Remove confirm_approval from UIHandler Protocol body (documented as optional)
- Remove confirm_approval from BatchUIHandler (no interactive approval)
- Remove isinstance check in _wire_approval_handler; hasattr is sole gate
- Remove confirm_approval from PrintUIHandler example
- Replace 2 batch tests with not hasattr assertion test

Net code reduction. Non-interactive path: no confirm_approval → not wired
→ PathGuardrail simple block fires. Interactive path unchanged.

🤖 Implemented together with a coding agent.

1284 of 1447 branches covered (88.74%)

Branch coverage included in aggregate %.

7287 of 8567 relevant lines covered (85.06%)

0.85 hits per line