dangernoodle-io / breadboard / 30302601871

97%

push

github

feat: defer provisioning portal teardown behind a settle state (B1-809 PR3a) (#1107)

- add WP_CLOSING state and EV_SETTLE_TIMEOUT event to the pure provisioning policy FSM: EV_SAVE_SUCCESS now moves WP_ACTIVE -> WP_CLOSING (no teardown), and EV_SETTLE_TIMEOUT drives WP_CLOSING -> WP_IDLE via the unchanged act_close_portal (prov_stop -> ap_stop -> creds_arrived_notify)
- arm the settle timer in wp_closing_on_entry (an on_entry hook), not in row 7's action -- an action-armed timer is discarded on a concrete `next` per bb_fsm's contract, which would park the FSM in WP_CLOSING forever
- add settle_ms to wifi_prov_ctx_t and a third wifi_prov_fsm_init parameter so the settle duration stays out of this host-compilable TU (PR3b's ESP-IDF shell supplies it from Kconfig)
- wire the previously-unemitted WIFI_PROV_LOG_PORTAL_CLOSED into act_close_portal instead of adding a new log enum value
- pin the three deliberate no-op cells (WP_CLOSING + EV_SAVE_SUCCESS, WP_CLOSING + EV_ENTRY_USER_REQUESTED, WP_IDLE/WP_ACTIVE + EV_SETTLE_TIMEOUT) plus the full settle happy path and timer-armed/timer-cleared assertions

7820 of 8423 branches covered (92.84%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 1 file covered. (100.0%)

13315 of 13470 relevant lines covered (98.85%)

2617.59 hits per line