lsm / HyperNeo / 30300900226

83%

push

github

fix: GLM models missing from selector despite provider connected (#2265)

* fix: hydrate provider credentials from request on create/update

GLM models were missing from the selector despite GLM showing 'connected'
in the Provider panel. The live provider instance stayed un-hydrated
(isAvailable() === false) because provider-sync only calls setCredentials
when the credential-store read returned non-null, and the post-store
round-trip read can come back null (locked-keychain read, fallback miss).

resolveCredentialsForHydration hydrates the live instance directly from
the request value for API-key providers (the authoritative key just
entered), so isAvailable() flips true immediately without a daemon
restart. OAuth still prefers the store's normalised shape (raw metadata)
with a request fallback. Adds a filterModelsForPicker characterization
test confirming GLM models render when authenticated.

* fix: self-heal stale model cache when a provider is stranded

A non-empty model cache was trusted for its full 4h TTL, so a
connected provider whose models were absent (its getModels() failed
transiently when the cache was built, or credentials were hydrated
without a cache-clearing event) stayed hidden until the TTL elapsed.

models.list now detects a registered-and-available provider missing from
a non-empty cache and refreshes once per provider per cache lifetime.
A per-cache tried-set prevents a refresh storm when a provider's
getModels() persistently fails (invalid key, flaky upstream); the set is
reset by clearModelsCache() so a re-connect gets a fresh attempt.

* fix: only reset stranded-provider tracking on a full cache clear

refreshedMissingProviders.clear() ran on both branches of
clearModelsCache, including the session-scoped (keyed) branch invoked on
every model switch / query-lifecycle event. A session-scoped clear does
not change global provider availability, so wiping this global tried-set
there let any model switch re-probe every missing prov... (continued)

11629 of 16737 branches covered (69.48%)

Branch coverage included in aggregate %.

96 of 96 new or added lines in 3 files covered. (100.0%)

99096 of 117372 relevant lines covered (84.43%)

303.78 hits per line