hyperledger-labs / fabric-smart-client / 30294154788
81%

DEFAULT BRANCH: main
Ran
Jobs 17
Files 532
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 81.213% (-0.03%) from 81.245%
30294154788

push

github

web-flow 
feat(logging): extract context values into context-aware log lines as zap fields (#1608)

* feat(logging): extract registered context values into context-aware log lines

Context-aware log methods (InfowContext, ErrorfContext, ...) only used the
context to emit an OTel span event; nothing in it ever reached the zap log
line. Adds a declarative (context key -> field name) registry, configurable
via Init(Config{ContextLogFields: ...}) or RegisterContextLogField (mirrors
the existing Replacers pattern), so registered values are auto-attached to
every context-aware log call as zap.Any fields.

The decorator level-gates before extracting (SugaredLogger.Level() check) so
disabled log calls stay near-zero-cost regardless of registry size, and the
*w*Context methods append fields directly into keysAndValues instead of
calling With(), avoiding an extra logger-clone allocation on the enabled
path.

Refs #1607.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>

* perf(logging): make context-field extraction allocation-free when absent

Publish an immutable snapshot of registered ContextLogFields so the hot
read path avoids lock contention and per-call copies, and skip allocating
the combined args/fields slice until a registered key is actually found
in the context. Add benchmarks covering registry size and hit/miss
context scenarios, and a test covering a named string context key type.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>

* test(logging): cover dynamic registration and nested context wrapping

Add tests proving RegisterContextLogField affects already-constructed
loggers immediately, that repeated registrations accumulate rather than
replace, and that registered fields still resolve when the carrying
context is wrapped multiple times (WithValue/WithCancel/WithTimeout) after
the value was set.

Co-Authored-By: Claude Sonnet 5 <noreply@a... (continued)

32305 of 39778 relevant lines covered (81.21%)

2582.68 hits per line

Coverage Regressions

Lines Coverage ∆ File
59
57.25
 -7.46% platform/common/services/logging/otel.go
8
87.88
 14.55% platform/common/services/logging/config.go
2
92.94
 -1.18% platform/view/services/metrics/prometheus/provider.go
Jobs
ID Job ID Ran Files Coverage
1 itest-fabric-atsachaincode - 30294154788.1 479
28.2
 GitHub Action Run
2 itest-fabricx-multiendorsement - 30294154788.2 501
26.03
 GitHub Action Run
3 itest-fsc-pingpong - 30294154788.3 272
30.02
 GitHub Action Run
4 itest-fabric-iouhsm - 30294154788.4 484
36.84
 GitHub Action Run
5 itest-fabricx-iou - 30294154788.5 503
26.34
 GitHub Action Run
6 itest-fabric-events - 30294154788.6 479
25.66
 GitHub Action Run
7 itest-fabricx-deployment - 30294154788.7 501
25.99
 GitHub Action Run
8 itest-fsc-signedpingpong - 30294154788.8 270
27.12
 GitHub Action Run
9 itest-fabric-twonets - 30294154788.9 474
27.21
 GitHub Action Run
10 itest-fabricx-simple - 30294154788.10 501
25.33
 GitHub Action Run
11 utest-postgres - 30294154788.11 523
14.23
 GitHub Action Run
12 itest-fabric-stoprestart - 30294154788.12 474
28.9
 GitHub Action Run
13 itest-fabric-iou - 30294154788.13 484
37.59
 GitHub Action Run
14 utest - 30294154788.14 523
72.94
 GitHub Action Run
15 itest-fabric-atsa - 30294154788.15 474
40.45
 GitHub Action Run
16 itest-fsc-stoprestart - 30294154788.16 272
28.77
 GitHub Action Run
17 itest-fabric-runtimeconfig - 30294154788.17 484
35.47
 GitHub Action Run
Source Files on build 30294154788