adobe / spectrum-web-components / 30262422736

96%

Build Type

push

github

Committed by web-flow

Commit Message

fix(menu): resolve double-toggle on Space/Enter selection (#6538)

The keydown handler called `focusElement.click()` (which already triggers
`selectOrToggleItem` via the click event chain) and then called
`selectOrToggleItem` again explicitly, causing the item's selection to
toggle on and immediately back off. Most visible with `selects="multiple"`,
where the final value reverted to empty after a keyboard press.

Fixes https://github.com/adobe/spectrum-web-components/issues/5825

Co-authored-by: Rajdeep Chandra <rajdeepc@adobe.com>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

Coverage Stats

6018 of 6462 branches covered (93.13%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

37932 of 39207 relevant lines covered (96.75%)

461.65 hits per line