adobe / spectrum-web-components / 30121412344

96%

push

github

refactor(core): lean out SpectrumElement (#6523)

* refactor(core): lean out SpectrumElement

Trim SpectrumElement to only what every 2nd-gen component needs:

- Extract `hasVisibleFocusInTree` into the `isFocusVisibleInTree(root)` utility
  (mirrors the existing `getActiveElement` util it wraps); add a unit test and
  export from `@adobe/spectrum-wc-core/utils`. No 2nd-gen component consumed the
  method.
- Remove the `get dir()` override. 2nd-gen resolves direction via
  `getComputedStyle(...).direction` at each call site; nothing read `element.dir`.
- Remove the now-empty `SpectrumMixin` / `SpectrumInterface`. Their only remaining
  job was a non-null `shadowRoot` retype nothing relied on (all reads use `?.`).
  `SpectrumElement` now extends `LitElement` directly.
- Drop the stale `hasVisibleFocusInTree` / `dir` entries from the Storybook
  argTypes hide-list.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* test(core): strengthen isFocusVisibleInTree coverage; docs: util-based API

Address review feedback on the SpectrumElement cleanup:

- Rewrite the util test to actually exercise every branch: keyboard focus via
  `userEvent.tab()` proves the true (`:focus-visible`) branch; programmatic focus
  on a button proves the "active but not focus-visible" false branch; and an empty
  attached shadow root proves the `root` argument scopes the query. Drops the
  meaningless detached-shadow-root check and the redundant fixture null-guard.
- Update the focus-management contributor guide to document the
  `isFocusVisibleInTree(root)` utility instead of the removed
  `SpectrumElement.hasVisibleFocusInTree()` method; regenerate nav.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* test(core): drop flaky programmatic-focus assertion from isFocusVisibleInTree

Chromium and WebKit paint :focus-visible on a programmatic .focus() when no
mouse-down preceded it, so the "active but not :focus-visible" case was not
deterministic. Remove it; the n... (continued)

6023 of 6466 branches covered (93.15%)

Branch coverage included in aggregate %.

37935 of 39208 relevant lines covered (96.75%)

461.16 hits per line