agama-project / agama / 30260798705

83%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(web): improve storage device names truncation (#3746)

## Summary

- Replace the `truncate?: boolean` argument with a `{ truncate,
maxLength, omission, tolerance }` options object, so call sites read
clearly and can control the length, the marker, and how far a name may
exceed the limit before it is shortened at all.
- Let `TruncatedDeviceName` receive `maxLength` as a prop, so each table
sets it next to its own column width instead of the component hardcoding
one.


## What changed

- **Options object.** `baseName`, `deviceBaseName` and `deviceLabel`
take an optional `BaseNameOptions`:
  - `truncate` opts into shortening (replaces the old boolean).
- `maxLength` is the length to truncate to; it defaults to the shared
sentence-text length, so callers that want the previous behavior just
pass `{ truncate: true }` and never repeat the constant.
- `omission` is the middle marker (default `"…"`), now configurable; the
truncation math accounts for its length so the result always stays
within `maxLength`.
- `tolerance` is how far a name may exceed `maxLength` and still be
shown in full. It defaults to `omission.length + 2`, so truncation only
kicks in when it saves clearly more width than the marker itself
occupies (no swapping a few real characters for a similar-length
marker).
- **`TruncatedDeviceName` takes `maxLength`.** The component no longer
hardcodes a width; each storage table passes the value beside its column
style, keeping the number and the width it fits within in one place.
- **Dropped a stale FIXME** pointing at PatternFly's `Truncate`, found
unsuitable for the fixed-width table case in #3745.

Coverage Stats

4909 of 6845 branches covered (71.72%)

Branch coverage included in aggregate %.

26 of 29 new or added lines in 12 files covered. (89.66%)

20 existing lines in 3 files now uncovered.

25583 of 29827 relevant lines covered (85.77%)

123.86 hits per line