agama-project / agama / 30255810007

83%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(web): drop leftover route handle metadata (#3760)

## Problem

The installer used to have a sidebar. It walked the route tree and
rendered one link per top level route, taking the label and the icon
straight from the metadata attached to each route. That is what the
metadata was for, and while the sidebar existed it was the single source
for those labels.

The interface revamp (#3009, January 2026) replaced that navigation with
today's overview page and breadcrumbs, taking the sidebar with it. The
metadata was only partially removed then, and the rest was left in place
on every route, where it has stayed ever since.

It has had no reader in all that time: no screen inspects the metadata
of the matched route, and the route list that used to be handed to the
sidebar has no callers outside the router itself. In practice this left
a second, hand copied set of page names and icons sitting next to the
real ones, with nobody to consume it and no signal when the two drifted
apart.

## Solution

Delete these left overs. If a future screen wants page titles derived
from the route tree, it will need a fresh design anyway: most routes
never had this metadata to begin with, so there was never enough here to
build on.

## About the translated strings

Deleting the metadata also deletes nine strings that were marked for
translation: System, Localization, Network, Authentication, Software,
Registration, Storage, DASD, and ZFCP.

This is safe, and worth spelling out:

- Eight of the nine appear elsewhere in the interface, in breadcrumbs
and overview cards. Those references keep the strings in the catalog, so
existing translations stay in use exactly as before.
- Only "ZFCP" loses its last reference. That one was never displayed:
the page users reach spells it "zFCP", which is a separate entry and
stays untouched. Its translations are also identical to the original in
every language that has one, since it is an acronym.

No text visible in the interface loses ... (continued)

Coverage Stats

4896 of 6832 branches covered (71.66%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

25543 of 29791 relevant lines covered (85.74%)

123.84 hits per line