nats-io / nats-server / 30241220726
77%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 67
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 78.265% (+1.7%) from 76.546%
30241220726

push

github

web-flow 
[FIXED] MQTT: QoS2 message released on a resumed session lost its QoS and PI (#8414)

This came up while testing with
https://github.com/ConnectEverything/mqtt-test/pull/4

Two root causes. The delivery callbacks and the retain handling read the
publishing connection's c.mqtt.pp — the last PUBLISH parsed — which is
stale for a PUBREL- or will-initiated delivery, so a QoS2 message
released after a reconnect was delivered as QoS0 with no packet
identifier. And the staged copy in $MQTT_qos2in never persisted the
retain flag, so it could not be recovered on another connection at all.
Same-connection flows worked only while the scratch happened to still
hold the right packet. Because of the interplay, the two must be fixed
together.

The delivered message now becomes the client's current publish for the
duration of the broadcast (swapped into the readLoop-owned c.mqtt.pp,
restored by the same defer as the pubargs); wills build their own
mqttPublish and use the common path instead of writing into the scratch
by hand. The staged copy
persists the retain flag in a second, flags byte of the Nmqtt-Pub header
value, restored when the PUBREL rebuilds the publish; older servers read
only the first (QoS) byte, and messages without a flags byte read as not
retained.

Retained QoS2 messages now survive an in-flight reconnect: a PUBLISH
staged on one connection and released by the PUBREL on the next stores
the retained message, where before the retain bit died with the first
connection's parser state. This matches Spec [MQTT-4.3.3] Method A as
implemented by mosquitto, which likewise persists the retain flag with
the staged message and applies it at release, together with the
delivery.

Added regression tests: a PUBREL on a resumed session delivers at the
subscription's QoS exactly once, a retransmitted PUBREL is acknowledged
without redelivering, and the retain flag survives the staging round
trip.

74043 of 94606 relevant lines covered (78.26%)

527216.96 hits per line

Coverage Regressions

Lines Coverage ∆ File
58
82.78
 -0.35% src/github.com/nats-io/nats-server/server/jetstream_cluster.go
18
87.91
 0.16% src/github.com/nats-io/nats-server/server/consumer.go
10
85.18
 0.0% src/github.com/nats-io/nats-server/server/events.go
9
86.86
 -0.03% src/github.com/nats-io/nats-server/server/accounts.go
9
80.06
 -0.03% src/github.com/nats-io/nats-server/server/raft.go
7
56.68
 -0.43% src/github.com/nats-io/nats-server/server/jetstream_errors_generated.go
7
63.77
 0.63% src/github.com/nats-io/nats-server/server/opts.go
4
86.32
 -0.03% src/github.com/nats-io/nats-server/server/stream.go
3
74.61
 0.45% src/github.com/nats-io/nats-server/server/jetstream_api.go
2
78.74
 0.0% src/github.com/nats-io/nats-server/server/filestore.go
2
84.92
 -0.09% src/github.com/nats-io/nats-server/server/jetstream.go
1
89.95
 1.07% src/github.com/nats-io/nats-server/server/client.go
Jobs
ID Job ID Ran Files Coverage
1 30241220726.1 67
78.26
 GitHub Action Run
Source Files on build 30241220726