ruby-grape / grape / 30240310323

97%

master: 97%

Pull #2830

github

Resolve inheritable settings by walking parent

Each InheritableSetting held an InheritableValues layered over the store
of the scope it inherited from, so the parent relationship was encoded
twice: once as @parent, once as that chain, kept in sync by
produced #2794, where handlers were written to and read from different
stores.

Keep a scope's own overrides in a plain Hash — nil until first write,
like @stackable_values — and resolve reads against #parent, the same
move StackableValues got in #2823. InheritableValues then has nothing
left to do and is removed, along with its unreachable #merge and

Resolution is unchanged: reads key off presence rather than truthiness,
so a scope can still override an inherited value with an explicit nil
(#cascade relies on this), #inheritable? still reports an assignment
made anywhere along the chain, and the chain stays live, so a value an
enclosing scope gains later is visible through scopes already nested
inside it. The deleted class's spec is replaced by coverage of those
invariants through InheritableSetting's own API, where they were
previously untested.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

1185 of 1274 branches covered (93.01%)

Branch coverage included in aggregate %.

3791 of 3858 relevant lines covered (98.26%)

26084.84 hits per line