ruby-grape / grape / 30239089784

97%

master: 97%

Build Type

Pull #2829

github

Committed by ericproulx

Commit Message

Let a cascading route hand over to every remaining route

Router#transaction sent a cascading match straight to the greedy
neighbour — the last route registered for the path — and returned its
answer, so any route registered between the first match and that last
one was unreachable. With three mounted API versions plus a catch-all
`route :any, '*path'`, v1 and v3 were served while v2 answered 406; the
shortcut only ever looked correct with exactly two versions, where "the
last route" happens to be the sibling.

Try the method's remaining routes (#rotation) as soon as a match
cascades, before the ANY routes and the greedy neighbour, and keep the
priority order otherwise intact. A consequence, and what cascade: true
means: with a catch-all present, an unmatched version now falls through
to it rather than surfacing the versioner's 406. cascade: false still
answers 406 immediately and never consults the catch-all.

Also close the body of every superseded cascading response — Rack
requires it, and rotation previously leaked them (Rack::Lint flagged
this as soon as a third sibling made the path reachable).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Pull Request Pull Request #2829: Let a cascading route hand over to every remaining route

Coverage Stats

1191 of 1282 branches covered (92.9%)

Branch coverage included in aggregate %.

30 of 31 new or added lines in 1 file covered. (96.77%)

1 existing line in 1 file now uncovered.

3816 of 3883 relevant lines covered (98.27%)

25820.11 hits per line