valkyrjaio / valkyrja-php / 30236752593
100%

DEFAULT BRANCH: 26.x
Ran
Jobs 1
Files 1138
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
30236752593

push

github

web-flow 
[Cli] Add routing attribute parameter combination tests (#928)

# Description

Follow-up to the merged CLI routing combination tests (#924), bringing
PHP to parity with
the additional attribute coverage added to the Java port
(valkyrjaio/valkyrja-java#49, merged).

Java #49 asserts, in one focused test, that the annotation path converts
a full matrix of
argument and option modes/value-modes into the expected data-class
parameters — checking
every converted field (mode, value mode, short names, valid values,
default, display name),
not just that a parameter is present. This adds the equivalent PHP
fixture and test so both
ports assert the same matrix. Test-only; no source changes.

## Types of changes

- [x] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

-
**`tests/Tests/Unit/Cli/Routing/Collector/AttributeRouteCollectorTest.php`**
— added `testGetCommandsWithParameterCombinations` asserting the
attribute path converts a full matrix — argument REQUIRED/DEFAULT and
OPTIONAL/ARRAY; option REQUIRED/DEFAULT (with short names, valid values,
default, display name), OPTIONAL/NONE, and OPTIONAL/ARRAY — into
data-class parameters with the expected fields.
-
**`tests/Tests/Fixtures/Cli/Routing/Command/CommandWithParameterCombinationsFixture.php`**
— new command fixture mirroring the Java
`CliRoutingCombinationsController`.

12591 of 12591 relevant lines covered (100.0%)

17.36 hits per line

Jobs
ID Job ID Ran Files Coverage
1 30236752593.1 1138
100.0
 GitHub Action Run
Source Files on build 30236752593