valkyrjaio / valkyrja-php / 30234094550
100%

DEFAULT BRANCH: 26.x
Ran
Jobs 1
Files 1138
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
30234094550

push

github

web-flow 
[Http] Move misfiled RouteFactory from Cli to Http namespace (#927)

# Description

`RouteFactory` lived under the `Cli\Routing\Factory` namespace but
builds **HTTP** routes — it imports `Valkyrja\Http\Routing\Data\{Route,
DynamicRoute, …}` and `Valkyrja\Http\Struct\…`, and is imported/used
only by the HTTP `AttributeRouteCollector`. It was simply misfiled. This
moves it to `Http\Routing\Factory\RouteFactory` where it belongs.
Behavior is identical — only the namespace/location changed.

The CLI `AttributeRouteCollector` converts route attributes to data
inline (`convertAttributeToData()`) and needs no CLI route factory, so
none was introduced.

_Note (no change here): Java's
`io.valkyrja.cli.routing.factory.RouteFactory` correctly builds CLI
routes (not this bug) and appears unused; TypeScript has no such
factory._

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [x] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`src/Valkyrja/Http/Routing/Factory/RouteFactory.php`** — moved from
`src/Valkyrja/Cli/Routing/Factory/RouteFactory.php`; namespace changed
`Cli\Routing\Factory` → `Http\Routing\Factory` (imports unchanged —
already all `Http\…`).
- **`src/Valkyrja/Http/Routing/Collector/AttributeRouteCollector.php`**
— updated the `use` import to the new
`Http\Routing\Factory\RouteFactory` FQCN.
- **`tests/Tests/Unit/Http/Routing/Factory/RouteFactoryTest.php`** —
moved from `tests/Tests/Unit/Cli/Routing/Factory/RouteFactoryTest.php`;
namespace and `RouteFactory` import updated.

12591 of 12591 relevant lines covered (100.0%)

17.33 hits per line

Jobs
ID Job ID Ran Files Coverage
1 30234094550.1 1138
100.0
 GitHub Action Run
Source Files on build 30234094550