valkyrjaio / valkyrja-starter-app-php / 30234780537

100%

push

github

[Application] Add RoadRunner runtime end-to-end test (#169)

# Description

Adds the **RoadRunner** runtime to the starter app with a real
end-to-end test,
the second of the per-runtime follow-ups to #168 (which introduced the
shared
server harness and the HTTP + OpenSwoole runtimes). This PR is stacked
on #168 —
please merge #168 first.

The app can now be served under RoadRunner
(`app/bin/roadrunner-worker.php` +
`.rr.yaml`), and `RoadRunnerEntryTest` runs the real `rr serve` server,
which
spawns the worker, and asserts a live `GET /` renders the welcome view —
exercising the framework's RoadRunner request/response bridge end to
end. This
was verified locally against `rr` 2025.1.12 + `spiral/roadrunner-http`
v4.1.0.

Because the shared PHPUnit workflow has no hook to fetch a server
binary, a
dedicated `RoadRunner E2E` CI job downloads the RoadRunner server via
`spiral/roadrunner-cli` and runs the test. `RoadRunnerEntryTest`
self-skips when
the `rr` binary, the RoadRunner PHP worker package, or the framework
bridge is
unavailable, so it never fails against an incomplete environment.

`App\RoadRunner\App` is covered by a unit test (the e2e runs it in a
subprocess,
which coverage cannot measure), keeping line coverage from regressing.

## Types of changes

- [x] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`app/src/App/RoadRunner/App.php`** — RoadRunner entry for the app
(throwable-handler overrides mirroring `App\Http\App`).
- **`app/bin/roadrunner-worker.php`** — the RoadRunner PHP worker that
boots the app under `rr`.
- **`.rr.yaml`** — RoadRunner server config (worker command, HTTP/RPC,
single worker).
- **`app/... (continued)

6 of 6 new or added lines in 1 file covered. (100.0%)

324 of 324 relevant lines covered (100.0%)

1.67 hits per line