valkyrjaio / valkyrja-starter-app-php / 30232926175

100%

push

github

[Application] Add HTTP and OpenSwoole runtime end-to-end tests (#168)

# Description

Adds real, over-the-socket end-to-end tests for the starter app's HTTP
runtimes,
booting the actual application in a subprocess server and asserting a
live
`GET /` renders the welcome view. This complements the existing
CGI-style
`HttpEntryTest`/`CliEntryTest` with true "start the server and hit it"
coverage
and introduces a shared harness the remaining worker runtimes will
reuse.

This first PR covers the two runtimes that can be exercised here: the
**standard
HTTP** runtime (PHP's built-in server over `app/public`) and the
**OpenSwoole**
runtime (a real OpenSwoole HTTP server via a new `app/bin/openswoole`,
exercising
the framework's OpenSwoole request/response bridge). Follow-up PRs will
add the
RoadRunner and FrankenPHP runtimes, each with the CI job needed to run
their
server.

To let the OpenSwoole e2e run — and because the OpenSwoole bridge only
serves
correctly as of `valkyrja/valkyrja` v26.5.2 — the dependency is bumped
to
`^26.5.2` and the PHPUnit CI job now loads the `openswoole` extension.
The
OpenSwoole test self-skips when the extension is absent or the installed
framework predates the bridge, so it never fails against an older
environment.

## Types of changes

- [x] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`app/tests/Tests/Functional/Abstract/RuntimeServerTestCase.php`** —
shared harness: reserves a free port, starts a server subprocess, waits
for it to listen, performs a GET, and always tears the process down.
- **`app/tests/Tests/Functional/Entry/HttpServerEntryTest.php`** —
serves `app/public` via PHP's buil... (continued)

13 of 13 new or added lines in 1 file covered. (100.0%)

318 of 318 relevant lines covered (100.0%)

1.67 hits per line