valkyrjaio / valkyrja-php / 30232758335

100%

push

github

[Cli] Enforce option valid values in areValuesValid (#925)

# Description

CLI option `validValues` (the allowed values for an option) were stored,
exposed via getters/withers, and carried through the
`AttributeRouteCollector` to help output — but never actually enforced.
`areValuesValid()` only checked the option `mode` (`REQUIRED` ⇒ at least
one option present) and `valueMode` (`DEFAULT` ⇒ at most one option); it
never checked that a provided value was a member of `validValues`. As a
result an option declared with `validValues` such as `['json', 'xml']`
still accepted `--format=csv`.

This PR enforces `validValues` in `areValuesValid()`: when `validValues`
is non-empty, every bound option value must be a member of
`validValues`, otherwise `validateValues()` throws the existing
`CliRoutingOptionValuesValidationException`. An empty `validValues`
imposes no constraint (unchanged). The check composes with `valueMode`
`NONE`/`DEFAULT`/`ARRAY` (for `ARRAY`, every provided value must be
valid) and with `OptionMode` `REQUIRED`/`OPTIONAL`.

PHP is the reference implementation; the Java and TypeScript ports
mirror its behavior. This is one of three sibling PRs — see **Sibling
PRs** below.

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [x] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes
- **`src/Valkyrja/Cli/Routing/Data/OptionParameter.php`** —
`areValuesValid()` now returns `false` (so `validateValues()` throws
`CliRoutingOptionValuesValidationException`) when any bound option value
is not a member of a non-empty `validValues` list; an empty list is
unconstrained.
- **`tests/Tests/Unit/Cli/Routing/Data/OptionParameterTest.php`** —
added combination tes... (continued)

4 of 4 new or added lines in 1 file covered. (100.0%)

12591 of 12591 relevant lines covered (100.0%)

17.33 hits per line