valkyrjaio / valkyrja-php / 30232707721
100%

DEFAULT BRANCH: 26.x
Ran
Jobs 1
Files 1138
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
30232707721

push

github

web-flow 
[Http] Add routing path/regex/parameter combination tests (#923)

# Description

The HTTP routing code (`Processor`, `Matcher`,
`AttributeRouteCollector`) already
reported 100% line and branch coverage, but that coverage was shallow on
*combinations*: the existing tests exercised a single parameter type,
one optional
parameter, one non-capturing parameter, etc. — enough to touch each
line/branch once,
but not enough to prove that arbitrary developer-authored routes produce
the correct
regex and match correctly.

This PR adds combination-matrix tests so a developer can trust that any
route they
define — via direct `Route`/`DynamicRoute` construction **or** via
attributes — produces
the expected regex and matches request paths correctly. It adds tests
only; there are no
source changes, so coverage cannot drop.

Highlights:
- **Exact regex production** is now asserted (not just non-empty) across
every `Regex`
parameter type, structural layouts (parameter at start/middle/end,
multiple/adjacent
parameters, static+dynamic mixes), and modifiers (optional, multiple
optional,
non-capture, optional+non-capture, the `{name?}` auto-optional path),
plus the guard
  branches. Each produced regex is also asserted to be valid PCRE.
- **Matching correctness** is verified per parameter type (valid input
matches and binds,
invalid input is rejected) and — for the first time — **request-method
filtering**
(every prior `Matcher` test used `RequestMethod::ANY`), trailing-slash
normalization,
static-over-dynamic precedence, multi-parameter extraction, and
non-capturing
  parameters not being bound.
- The **attribute construction path** is asserted to produce the same
regex as direct
  construction via a new controller fixture.

Part of a cross-language effort; sibling Java and TypeScript PRs will
follow.

## Types of changes

- [x] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-break... (continued)

12587 of 12587 relevant lines covered (100.0%)

17.33 hits per line

Jobs
ID Job ID Ran Files Coverage
1 30232707721.1 1138
100.0
 GitHub Action Run
Source Files on build 30232707721