kobotoolbox / kpi / 30230642179

82%

master: 76%

Build Type

push

github

Committed by web-flow

Commit Message

fix(admin): correct CORS configuration guidance DEV-2471 (#7284)

### 👷 Description for instance maintainers
Fix CORS configuration guidance in the Django Admin interface so that it
correctly says NOT to add default ports 80 or 443 for HTTP or HTTPS,
respectively. Add a validator to prevent saving new origins if this
guidance is not heeded.

### 👀 Preview steps
1. Go to `/admin/external_integrations/corsmodel/add/`
2. Check that the help text includes "Do not include the default port
for the scheme (80 for http, 443 for https)"
3. Attempt to add `http://some-origin:80` and `https://some-origin:443`:
both should fail
4. Attempt to add an oddball `http://some-origin:443`: it should succeed

Coverage Stats

9523 of 12839 branches covered (74.17%)

2 of 9 new or added lines in 2 files covered. (22.22%)

7 existing lines in 2 files now uncovered.

30827 of 37660 relevant lines covered (81.86%)

5.51 hits per line