ruby-grape / grape / 30209553439

97%

master: 97%

Pull #2823

github

Move stackable settings storage onto InheritableSetting

Stackable registrations now live on `Grape::Util::InheritableSetting`
itself — one plain `key => Array` Hash per scope, allocated on first
write — and inheritance is resolved by walking `#parent`, the same
recursion `#rescue_handlers` already used. Previously they lived in a
`StackableValues` instance that maintained its own parallel chain via
`#inherited_values`, so every scope carried two links to its parent and
every registration read as an assignment (`store[:helpers] = mod`) that
actually appended.

The 28 raw store pokes inside the class become a two-method seam:
`stack(key, value)` to append and `stacked(key)` to read the chain
(plus `unstack` / `stacked_keys`). `stack` returns the registered value
because it replaced an assignment expression, whose value the `add_*`
writers — and `DSL::Routing#namespace` through them — silently returned.

`StackableValues` is kept as a read-only view, rebuilt on demand by
`#namespace_stackable`, purely because grape-swagger reads that store
directly: it walks the `#inherited_values` chain and reads each level's
`#new_values` to recover per-scope registrations, which no semantic
accessor exposes. Its `#[]=` and `#delete` are gone and its constructor
now takes `(new_values, inherited_values)`. Once grape-swagger reads the
accessors instead, deleting the class is a one-file change.

`Grape::Util::BaseInheritable` is removed: it only existed to share
plumbing between the two stores, and with `StackableValues` no longer a
store it had one subclass and one now-dead method (`#keys`). Its
contents moved into `Grape::Util::InheritableValues` unchanged.

Settings semantics are otherwise identical, verified against the
previous commit by diffing grape-swagger's generated swagger doc for a
nested `route_param` API. Two pre-existing quirks are preserved rather
than fixed, and are now documented: stack readers hand back the backing
Array when only one scope registered... (continued)

1156 of 1250 branches covered (92.48%)

Branch coverage included in aggregate %.

3784 of 3851 relevant lines covered (98.26%)

21601.07 hits per line