dangernoodle-io / breadboard / 30186128440

97%

push

github

fix: degrade doc-only schema-compose failures in storage and reboot route init (#1098)

Converts the 4 remaining ROUTE-OUTAGE sites (B1-1231) from fatal-abort to
degrade-and-continue: a doc-only OpenAPI schema-compose failure
(CONFIG_BB_OPENAPI_RUNTIME_META only) must never take down real route
registration.

- platform/espidf/bb_diag_http/bb_storage_http_routes.c:
  bb_storage_http_factory_reset_routes_init() (POST /api/diag/factory-reset
  request schema) and bb_storage_http_routes_init() (DELETE /api/diag/storage
  request AND response schema) now warn-and-continue instead of returning the
  compose rc. Both request-schema sites are buffer-based (request_schema
  always points at a static buffer, never NULL); an unpatched empty buffer
  degrades safely because bb_http_resp_json_obj_set_raw() rejects a
  zero-length raw value and never emits the "schema" key, so the requestBody
  content block comes out empty rather than corrupting the emitted document.
  The response schema already starts NULL and is patched only on success
  (gated by bb_openapi_emit.c's `if (r->schema)`).
- platform/espidf/bb_system/bb_system_routes.c: bb_system_routes_init()
  (POST /api/reboot request schema) gets the same treatment. Adds
  `#include "bb_log.h"` and a file TAG ("bb_system_routes") -- this file had
  neither before, since it never logged. TAG is declared inside
  `#if defined(CONFIG_BB_OPENAPI_RUNTIME_META)`, guarding it with its sole
  use site (the compose-failure warning log), since the default config
  leaves it otherwise unreferenced -- same posture as
  bb_wifi_http_routes.c's TAG guard.
- No CMakeLists changes: bb_log was already PRIV_REQUIRES in both
  components/bb_diag_http/CMakeLists.txt and components/bb_system/CMakeLists.txt.
- All three init functions are portable and genuinely host-compiled (see
  test_route_schema_literals_live.c and each component's own
  bbtool-scaffold-hint), so the new degrade branches are host-testable, unlike
  the ESP_PLAT... (continued)

7794 of 8397 branches covered (92.82%)

Branch coverage included in aggregate %.

13245 of 13400 relevant lines covered (98.84%)

2621.36 hits per line