dangernoodle-io / breadboard / 30177113050

97%

push

github

refactor: migrate bb_log_event to bb_data_http_describe() seam (B1-1220 PR2) (#1084)

Pilot migration for the B1-1220 seam (#1080/#1081): bb_log_event.c now calls bb_data_http_describe("log", "log", "LogEvent", schema) instead of the legacy bb_openapi_register_topic_schema(). key and topic are both "log" (also the bb_data key this producer binds under and the /api/events SSE topic name).

bb_log_event no longer links bb_openapi at all -- CMakeLists.txt drops it from REQUIRES (it had no public-header justification there either) and adds bb_data_http to PRIV_REQUIRES (internal .c use only), fixing B1-1221. bb_log_event's own link-closure edge into bb_openapi is gone (verified via bbtool's composition resolver, reversed pre- vs post-migration); bb_openapi still appears in examples/floor's overall closure via other producers (bb_diag_http, bb_system, etc.), which is unaffected and expected.

examples/smoke's composition root (entry_espidf.c) now wires bb_openapi_set_topic_source_fn(bb_data_http_describe_foreach); the slot is read lazily, per-request, inside openapi_handler() -> bb_openapi_emit_stream(), so it only needs to land before the first GET /api/openapi.json, not strictly before bb_app_init_rest() -- smoke's emitted document is unchanged, "log" still appears in components/schemas and the /api/events SSE oneOf, exactly as before this migration. examples/floor does not wire it: floor's app_main() never calls bb_app_init()/bb_app_init_rest() at all (its generated composition root is compiled-but-dead, proof-only), so floor never emitted /api/openapi.json either before or after this change -- untouched.

The new bb_data_http_describe() call is doc-only bookkeeping (feeds /api/openapi.json schema synthesis) and is non-fatal on failure: it logs a warning and falls through rather than aborting bb_log_event_init(), since bb_data_http_describe()'s backing table (BB_DATA_HTTP_MAX_DESCRIBE) is shared, first-come, no-eviction, and can legitimately be full by ... (continued)

7770 of 8375 branches covered (92.78%)

Branch coverage included in aggregate %.

13254 of 13412 relevant lines covered (98.82%)

2591.24 hits per line