dangernoodle-io / breadboard / 30176795379

97%

push

github

fix: don't abort bb_log_event_init() on a doc-only schema-compose failure (#1083)

bb_log_event_init()'s CONFIG_BB_OPENAPI_RUNTIME_META branch returned early (return schema_rc;) when bb_log_event_line_ensure_schema_patched() failed, aborting init entirely -- no queue, no forwarder task (the log topic's SSE attach itself is unaffected, but yields no data). Schema composition is documentation-only (/api/openapi.json), so a compose failure must never take down the logging subsystem's own bring-up. Now warn and fall through, matching the same degrade-and-continue posture as the other doc-only call in this function.

Registration is now guarded on schema_rc == BB_OK: on failure, bb_log_event_line_ensure_schema_patched() guarantees the schema buffer is left empty, and bb_openapi_register_schema() rejects only a NULL literal, not an empty one -- registering an empty literal would splice "LogEvent": with no value into /api/openapi.json, corrupting the entire document, not just log's entry. A compose failure now degrades to "no LogEvent entry in the document" instead.

This early-return was pre-existing on main -- it is a latent bug independent of, and predates, any bb_data_http_describe() migration.

Also batches in B1-1199's remaining -Wcomment site: rephrase test_dispatch_api.c's regression comment from the literal "/api/*" to "/api/{name}" so the block comment no longer trips -Wcomment under -Werror host builds, matching the convention already applied to bb_diag_http.h/bb_wifi_prov.h by prior PR #1038.

7770 of 8375 branches covered (92.78%)

Branch coverage included in aggregate %.

13254 of 13412 relevant lines covered (98.82%)

2589.06 hits per line