dnsimple / erldns / 30162016514

88%

Build Type

push

github

Committed by web-flow

Commit Message

Find the OPT RR anywhere in the additional section (RFC 6891 §6.1.1) (#359)

* Upgrade dns_erlang

* Find the OPT RR anywhere in the additional section (RFC 6891 §6.1.1)

RFC 6891 §6.1.1: an OPT RR "MAY be placed anywhere within the additional
data section". Two pipes matched it only at the head of that list, and
dns_erlang hands the section back in wire order, so [A, OPT] is exactly
what a legal query yields -- clients commonly put the OPT last.

erldns_edns_ede fell to its "no OPT here" branch and prepended a second
one, producing a response with two OPT RRs, which the same section
forbids. erldns_edns_max_payload_size fell through untouched, leaving a
client's oversized payload size unclamped, so the response could exceed
the 1232-byte fragmentation cap that pipe exists to enforce.

Both now go through erldns_edns:find_optrr/1 and replace_optrr/2, which
scan and then swap the record in place, leaving it where it was and every
other record untouched. erldns_edns already scanned correctly in
get_opts/2 and get_ede_errors/2, so this makes the module consistent with
itself.

Each test was checked against the head-only code first: with it restored,
ede_pipeline_optrr_not_first and max_payload_size_optrr_not_first both
fail.

* Update changelog

Coverage Stats

13 of 0 new or added lines in 0 files covered. (NaN%)

3 existing lines in 2 files now uncovered.

1674 of 1909 relevant lines covered (87.69%)

5733.45 hits per line