microlinkhq / browserless / 30153848888

79%

Build Type

push

github

Committed by web-flow

Commit Message

fix(pdf): wait for SPA content before printing (#852)

* fix(pdf): wait for SPA content before printing

Blank bot-check shells and overflow-scroller slides were serialized
too early. Honor isPageReady, scroll lazy roots, and size pages from
report sheets when format is unset. Pass --mediaType=screen when the
site's print CSS breaks the layout.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(pdf): drop site-specific report selectors

Keep generic overflow unwrap and readiness; leave page size and
chrome hiding to the caller / mediaType.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(pdf): leave layout tweaks to styles/scripts

Site-specific overflow unwrap belongs with the caller via goto
inject options, not baked into pdf render.

Co-authored-by: Cursor <cursoragent@cursor.com>

* refactor: rename snapshot to paintSignals

Avoid confusion with screenshots / ava snapshots — the helper only
returns in-page paint/settle signals.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(pdf): drop isBlankShell from ready check

Match fullPage screenshot: white JPEG + isPageReady. Keep mediaType
at render as the PDF-only capture option.

Co-authored-by: Cursor <cursoragent@cursor.com>

* chore: remove duplicate call

* perf: share full-document prep for pdf and fullPage screenshot

Extract prepareFullDocument (overflow wait, scroll, expand) and fix scroll
step delay so large timeouts no longer stretch dwell into multi-second steps.
CLI --timeout now also raises the browser context budget.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(pdf): tolerate mocked goto.timeouts without goto()

Fall back to timeouts.action when goto is absent, settle network without
goto.waitUntilAuto, and update unit expectations for scroll-time DOM quiet.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(pdf): clear remaining review findings

Run isPageReady on the paint fast path, pass goto response into
readiness checks, whitelist page.pdf opts, m... (continued)

Coverage Stats

696 of 858 branches covered (81.12%)

Branch coverage included in aggregate %.

134 of 368 new or added lines in 4 files covered. (36.41%)

1 existing line in 1 file now uncovered.

3708 of 4744 relevant lines covered (78.16%)

105621.87 hits per line