iotaledger / iota / 30138718525
69%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 1123
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 69.319% (+0.2%) from 69.133%
30138718525

push

github

web-flow 
feat(iota-node,iota-swarm-config): submit deny rule proposals on startup and epoch change (#12221) (#12232)

# Description of change

Part of #10749. Validators now announce their local
`TransactionDenyConfig` as a `DenyRuleProposal` through consensus, on
startup and on every epoch change (vote tracking is epoch-scoped).

- Submission hook in `IotaNode` next to the capabilities submit, gated
on `deny_rule_governance`; empty configs are not announced
- `DenyRuleProposal::new` stamps a wall-clock generation so a
resubmission supersedes earlier proposals (mirrors
`AuthorityCapabilitiesV1::new`)
- `TransactionDenyConfig::to_deny_rule_set()` converts the local config
to the full-state proposal payload
- `with_transaction_deny_config` knob through the validator
config/swarm/test-cluster builders (test infra)
- E2e simtest verifying proposals converge and become active on all
validators
- Doc fix in `post_consensus_validation.rs` left over from #12231

Stacked on the #12220 branch (PR #12231).

## Links to any relevant issues

Fixes #12221.

## How the change has been tested

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [x] Patch-specific tests (correctness, functionality coverage)
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] I have checked that new and existing unit tests pass locally with
my changes

86 of 139 new or added lines in 8 files covered. (61.87%)

3441 existing lines in 86 files now uncovered.

169222 of 244121 relevant lines covered (69.32%)

475189.58 hits per line

Uncovered Changes

Lines Coverage ∆ File
18
87.02
 -0.23% crates/iota-node/src/lib.rs
11
71.37
 -1.45% crates/iota-swarm/src/memory/swarm.rs
9
90.99
 -0.24% crates/iota-core/src/authority/authority_per_epoch_store.rs
6
75.1
 -1.22% crates/test-cluster/src/lib.rs
5
80.44
 -0.73% crates/iota-swarm-config/src/network_config_builder.rs
4
84.33
 -0.79% crates/iota-swarm-config/src/node_config_builder.rs

Coverage Regressions

Lines Coverage ∆ File
288
83.53
 0.54% crates/iota-core/src/authority.rs
235
5.49
 0.09% crates/iota-tool/src/lib.rs
230
69.35
 0.0% crates/iota/src/client_commands.rs
180
0.0
 0.0% crates/iota-open-rpc/src/examples.rs
175
87.02
 -0.23% crates/iota-node/src/lib.rs
134
0.0
 0.0% crates/iota-tool/src/commands.rs
110
53.83
 -12.98% crates/iota-types/src/storage/shared_in_memory_store.rs
97
80.29
 0.0% crates/iota-types/src/crypto.rs
96
0.0
 0.0% crates/iota-indexer/src/ingestion/primary/prepare.rs
94
85.69
 -0.35% crates/iota-core/src/transaction_orchestrator.rs
89
81.6
 0.49% crates/iota-core/src/authority/authority_store_pruner.rs
89
0.0
 0.0% crates/iota-core/src/generate_format.rs
83
38.67
 0.0% crates/iota/src/keytool.rs
76
86.87
 1.37% crates/iota-config/src/node.rs
76
0.0
 0.0% crates/iota-indexer/src/apis/write_api.rs
76
91.2
 1.55% crates/iota-network/src/state_sync/mod.rs
71
0.0
 0.0% crates/iota-indexer/src/historical_fallback/reader.rs
68
62.15
 0.07% crates/simulacrum/src/lib.rs
66
88.64
 0.26% crates/iota-genesis-builder/src/lib.rs
66
0.0
 0.0% crates/iota-indexer/src/optimistic_indexing.rs
64
80.66
 0.0% iota-execution/latest/iota-adapter/src/execution_engine.rs
62
89.24
 0.21% crates/iota-network/src/discovery/mod.rs
62
18.14
 0.0% crates/iota/src/iota_commands.rs
48
48.47
 27.36% crates/iota-light-client/src/checkpoint.rs
43
89.76
 0.0% crates/iota-core/src/grpc_indexes.rs
43
0.0
 0.0% crates/iota-data-ingestion/src/main.rs
41
40.45
 40.45% crates/iota-data-ingestion-core/src/history/reader.rs
41
0.0
 0.0% crates/iota-ledger/src/lib.rs
40
67.38
 33.84% crates/iota-data-ingestion-core/src/reader/v2.rs
37
23.66
 0.0% crates/iota-json-rpc-types/src/iota_checkpoint.rs
36
89.83
 0.0% crates/iota-grpc-server/src/types.rs
32
87.92
 0.0% crates/iota-types/src/messages_checkpoint.rs
29
41.49
 0.0% crates/iota-tool/src/db_tool/db_dump.rs
27
85.86
 -0.28% crates/iota-core/src/storage.rs
24
87.65
 -0.5% crates/iota-test-transaction-builder/src/lib.rs
24
32.8
 0.69% crates/iota-transactional-test-runner/src/lib.rs
24
68.94
 0.0% crates/iota-types/src/move_authenticator.rs
23
50.7
 -2.24% crates/iota-types/src/full_checkpoint_content.rs
22
59.26
 0.0% crates/iota/src/signing.rs
21
75.1
 -1.22% crates/test-cluster/src/lib.rs
18
77.24
 0.0% crates/iota-keys/src/key_derive.rs
18
64.55
 0.13% crates/simulacrum/src/store/in_mem_store.rs
17
83.84
 0.0% crates/iota-config/src/genesis.rs
15
94.49
 0.0% crates/iota-core/src/checkpoints/epoch_info.rs
15
70.9
 -6.72% crates/iota-storage/src/lib.rs
14
94.71
 0.0% crates/iota-core/src/checkpoints/checkpoint_executor/mod.rs
13
88.98
 0.0% crates/iota-config/src/migration_tx_data.rs
13
0.0
 0.0% crates/iota-light-client/src/object_store.rs
12
0.0
 0.0% crates/iota-ledger-signer/src/lib.rs
12
69.09
 -3.49% crates/iota-light-client/src/config.rs
12
93.7
 -0.43% crates/starfish/core/src/authority_service.rs
10
0.0
 0.0% crates/iota-analytics-indexer/src/handlers/checkpoint_handler.rs
10
83.13
 0.21% crates/iota-network/src/state_sync/builder.rs
10
84.33
 -0.79% crates/iota-swarm-config/src/node_config_builder.rs
9
88.81
 0.0% crates/iota-transaction-checks/src/deny.rs
9
95.93
 0.0% crates/iota-vm-sdk/src/executor/local_vm.rs
8
91.71
 -0.28% crates/starfish/core/src/header_synchronizer.rs
7
90.91
 0.0% crates/iota-light-client/src/proof.rs
6
92.11
 -0.03% crates/iota-core/src/authority/test_authority_builder.rs
6
55.06
 55.06% crates/iota-data-ingestion-core/src/history/manifest.rs
6
89.55
 -8.96% crates/iota-storage/src/blob.rs
6
67.5
 0.0% crates/iota-types/src/epoch_data.rs
5
85.05
 -0.27% crates/iota-json-rpc/src/read_api.rs
4
96.77
 -2.51% crates/iota-config/src/p2p.rs
4
42.86
 0.0% crates/iota-core/src/checkpoints/checkpoint_output.rs
4
73.2
 -2.06% crates/iota-core/src/test_utils.rs
4
85.42
 0.0% crates/iota-swarm-config/src/test_utils.rs
4
93.92
 0.0% crates/iota-types/src/auth_context/mod.rs
4
99.11
 0.0% crates/iota-vm-sdk/src/executor/prepare.rs
3
0.0
 0.0% crates/iota-light-client/src/graphql.rs
3
76.56
 -0.75% crates/iota-storage/src/object_store/util.rs
3
97.96
 -2.04% crates/iota-types/src/mock_checkpoint_builder.rs
2
85.11
 0.0% crates/simulacrum/src/store/mod.rs
1
86.11
 -2.78% crates/iota-cluster-test/src/test_case/native_transfer_test.rs
1
72.25
 0.0% crates/iota-core/src/authority_server/validator.rs
1
89.69
 0.34% crates/iota-core/src/connection_monitor.rs
1
98.62
 -0.28% crates/iota-core/src/signature_verifier.rs
1
99.47
 0.0% crates/iota-json-rpc/src/transaction_execution_api.rs
1
95.12
 -0.53% crates/iota-network/src/state_sync/metrics.rs
1
85.62
 -0.16% crates/iota-snapshot/src/writer.rs
1
77.78
 -3.7% crates/iota-storage/src/object_store/mod.rs
1
96.88
 0.0% crates/iota-types/src/signature.rs
1
92.83
 -0.08% crates/starfish/core/src/commit_syncer/fast.rs
1
98.07
 -0.1% crates/starfish/core/src/cordial_knowledge.rs
1
83.41
 -0.24% crates/starfish/core/src/core_thread.rs
1
96.86
 0.09% crates/starfish/core/src/dag_state.rs
Jobs
ID Job ID Ran Files Coverage
1 nextest+simtest - 30138718525.1 1123
69.32
 GitHub Action Run
Source Files on build 30138718525