moonbitlang / core / 5546

91%

Build Type

push

github

Committed by bobzhang

Commit Message

refactor(extends): uniformly promote compare/eq/hash; deprecate Default

Promotion policy is now driven by where the trait lives (see AGENTS.md):
builtin traits are cycle-free to promote; higher-package traits must use free
functions.

- `Compare::compare`, `Eq::equal`, `Hash::hash` — promoted UNIFORMLY on every
  type that impls them (all builtin traits, no cycle). Exactly one method per
  trait: the user-facing primary one. Their derivatives stay deprecated —
  `Compare::{op_lt,..}` (use `<` `<=` `>=` `>`), `Eq::not_equal` (use `!=`),
  `Hash::hash_combine` (implementer-facing). `compare`/`equal` are still worth
  promoting because they are the required trait methods and the only way to pass
  the operation as a first-class value.
  Tuples get the same promotions but `#doc(hidden)` (the `Tuple(N)::..` names are
  ugly in the interface; the methods still work with no warning).

- `Default::default` — deprecated everywhere (a literal or `Default::default()`
  via the trait is clearer), except `Byte::default` which is kept promoted for
  now because Moon's generated test drivers call it (moonbitlang/moon#1938
  removes that; deprecate once a moon release ships). `Type::default()` call
  sites rewritten to literals (`b'\x00'`, `[]`, `None`, `""`, `0`, ...) or the
  trait form where no clean literal exists.

Operators stay promoted; `Show::to_string` stays canonical-only; ToJson stays
as-is (belongs in @json, would cycle if promoted after the move).
FromJson/Arbitrary/Debug already deprecated.

Verified: `moon check --deny-warn --target all` clean; `moon test --build-only
--deny-warn` green on all four backends; `moon test --target all` green
(6780/6780/6736/6691).

Coverage Stats

21 of 22 new or added lines in 12 files covered. (95.45%)

3 existing lines in 3 files now uncovered.

15884 of 17406 relevant lines covered (91.26%)

196727.52 hits per line