umputun / agterm / 30124297746

98%

push

github

feat(keymap): allow arrow keys in chords (#291)

`parseKeybind` accepted only single-character keys plus tab/space/return/delete, so `map cmd+shift+left previous_session` failed with `invalid chord 'cmd+shift+left'` and no other spelling worked.

**What changed**

The four arrow names join the chord grammar, which lets the six actions that already ship on arrows (`focus_left_pane`, `focus_right_pane`, `previous_session`, `next_session`, and the two attention-nav ones) return their real chords from `BuiltinAction.defaultChord`. That removes the special case they needed: `arrowShortcut(for:)`, `arrowGlyphFallback`, and the `glyphHint` fallback are gone, so every keyed built-in resolves through one path. The generated starter `keymap.conf` also stops claiming `(no default)` for those six, which it did while their real chords lived only as hardcoded menu literals.

It closes a latent hole as well. The conflict checker resolves through `defaultChord`, so while the six returned nil their live chords were invisible to it, and `map cmd+opt+up new_session` would have silently double-bound the chord with no diagnostic.

A bare, modifier-less arrow is refused for `map`. A built-in becomes an always-on menu key equivalent with no text-field pass-through, so a bare arrow would swallow the key in the terminal, both palettes, the dashboard grid and every text field at once. Any modifier makes it bindable, and a bare non-arrow key stays legal as before.

The keyCode-to-name half of the `NSEvent` mapping moves into one host-free `namedKey(forKeyCode:)`. `CustomCommandRunner` and `UndoCloseShortcut` each carried their own copy, and a name the grammar accepts but a monitor cannot produce parses fine yet never fires; that exact failure shipped once already, for shifted symbols.

One behavior note worth knowing: widening the named-key set means a palette-only line whose shell command starts with a bare `up`/`down`/`left`/`right` now emits the same "must include a modifier... (continued)

36 of 36 new or added lines in 3 files covered. (100.0%)

5929 of 6061 relevant lines covered (97.82%)

4960547.73 hits per line