supabase / auth / 30115927049

72%

master: 72%

Build Type

Pull #2646

github

Committed by Chris Stockton

Commit Message

chore: modernize HandleResponseError to support errors.As

Replace the type switches in handleResponseError with errors.As
checks by dispatching to new functions for each error type:
* `HandleResponseError` creates log entry and apiVersion before
  calling private func `handleResponseError` which accepts the
  log and apiVersion. This heeps the recursion that happens in
  `handleResponseErrorCause` cause case from executing twice
  which can log two errors if invalid.
* `handleResponseError` contains a single switch statement that
  dispatches to one of the following funcs in the same sequence
  as previously.
    * `handleResponseErrorWeakPassword`
	* `handleResponseErrorHTTP`
	* `handleResponseErrorOAuth`
	* `handleResponseErrorCause`
	* `handleResponseErrorDefault`
* Each private err handler contains the previous code block for
  the type switch case and returns a bool to signal if the error
  was handled or not.

This should not include any behavior change today, it only
enables wrapping errors without hiding them in responses.

Pull Request Pull Request #2646: chore: modernize HandleResponseError to support errors.As

Coverage Stats

93 of 118 new or added lines in 1 file covered. (78.81%)

6 existing lines in 1 file now uncovered.

18321 of 25391 relevant lines covered (72.16%)

665.89 hits per line