orion-ecs / keen-eye / 30114885092

64%

Build Type

push

github

Committed by tyevco

Commit Message

fix(editor): Fix plugin init subscription leak, unreachable play-mode reload, and hot-reload CTS race (#1177,#1178,#1182)

#1177: EditorPluginManager.InstallPlugin and EnableDynamicPlugin now dispose
the context's event subscriptions when a plugin's Initialize throws, so a
dead plugin's handlers can never fire. RaiseSceneOpened guards each handler
so one plugin's fault cannot suppress others or escape into the caller.

Closes #1177

#1178: Entering play mode disables the file watcher, so its change callback
could never queue a deferred reload and edits made during play mode were
silently lost. HotReloadService now records the play-mode entry time and, on
exit, scans project sources for edits since that time, making the
pending-reload path reachable.

Closes #1178

#1182: HotReloadManager swapped the debounce CancellationTokenSource without
synchronization, so a concurrently-dispatched watcher event could dispose the
source between creation and token read, throwing ObjectDisposedException out
of an async void handler. The swap/dispose is now guarded by a Lock and the
token is captured inside it; the delay also catches ObjectDisposedException
defensively.

Closes #1182

Coverage Stats

8718 of 12744 branches covered (68.41%)

Branch coverage included in aggregate %.

38 of 45 new or added lines in 3 files covered. (84.44%)

130 existing lines in 17 files now uncovered.

51720 of 80654 relevant lines covered (64.13%)

1.0 hits per line