Freegle / Iznik / 28545

73%

push

circleci

fix(chat): bump latestmessage on delivery so replies to dormant rooms surface

A reply into a chat room dormant longer than the 31-day CHAT_ACTIVE_LIMIT did
not appear in the recipient's chat list for up to an hour, even though the
notification email fired within seconds. Freegle keeps one User2User room per
pair of members (reused across items), so a reply to a new post routinely lands
in a room whose last message was months/years ago.

ListForUser filters chat_rooms.latestmessage >= now - 31d, but neither
CreateChatMessage nor ChatProcessService bumped latestmessage - only the hourly
chats:update-counts recompute (ChatMaintenanceService) did. So the room stayed
outside the list window until that cron next ran; reload didn't help because the
backend genuinely omitted it. The email path keys off chat_messages.date, not
latestmessage, so it was unaffected - producing "email arrived but the chat
isn't showing" for ~43 min (real case: Torbrexbones, 2026-07-24).

Bump latestmessage when the message becomes deliverable, gated on the same
condition the email and in-app fetch use (not held for review, not spam):
- ChatProcessService::processIncoming - in the deliverable (!$review) branch.
- RippleReplyService::release - the rippling held-reply release path had the
  identical gap (release only set status='released').
GREATEST guards against moving latestmessage backwards. The hourly recompute
remains as a backfill; mod approval already bumps via updateMessageCounts.

Adds regression tests: deliverable reply bumps a dormant room's latestmessage;
a held-for-review reply does not.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01C8sWePQ4uPg39NoP3FcaJo

13383 of 17587 branches covered (76.1%)

Branch coverage included in aggregate %.

12 of 12 new or added lines in 2 files covered. (100.0%)

140586 of 194047 relevant lines covered (72.45%)

38.11 hits per line