kobotoolbox / kpi / 30099477289

82%

master: 76%

Build Type

push

github

Committed by web-flow

Commit Message

fix(projectOwnership): stop false transfer failures and improve admin transfer details DEV-2080 (#7294)

### 📣 Summary

Project ownership transfers are no longer reported as failed when the
transfer actually completed successfully.

### 📖 Description

Transferring projects could end as "failed" even though everything had
moved correctly — a single already-deleted file among thousands was
enough. A file that no longer exists cannot be moved, so it no longer
counts as a failure, and the same now applies when an internal retry
re-runs a step that had already finished. Genuine problems are still
reported, and a new log page shows what happened for a given project.

### 💭 Notes

- `ExtendedFieldFile.move()` raises `SourceFileMissingError` when the
source is gone; the two movers skip it instead of failing. A genuine
error still fails the task.
- `TransferStatus.update_status()` makes `success` terminal, so a late
or duplicate retry cannot downgrade a finished sub-task.
- A missing source can also mean an interrupted move (file relocated,
row never saved). `_recover_moved_file()` checks the target and
completes it — otherwise the record would keep pointing at a path
holding no file.
- `TransferStatusError.level` (migration `0008`) marks skips as `info`:
not counted on the invite page, not shown on the transfer page, listed
in the log admin. Indexed — skips vastly outnumber errors, so filtering
on `error` is selective — with the index gated on
`SKIP_HEAVY_MIGRATIONS`.
- 1000-transfer check: the invite summary stays at 2 queries, the
changelist status column at 0.

`validate_org_transfer.py` is deliberately not included; it stays a
draft.

### 👀 Preview steps

1. ℹ️ have a superuser and an invite whose transfers include both a
skipped file and a genuine error
2. go to `/admin/project_ownership/invite/<id>/change/`
3. 🔴 [on main] every transfer is dumped inline with its statuses and up
to 100 error records
4. 🟢 [on PR] one line — `N transfer(s): X failed · Y su... (continued)

Coverage Stats

9512 of 12833 branches covered (74.12%)

76 of 172 new or added lines in 8 files covered. (44.19%)

27 existing lines in 4 files now uncovered.

30810 of 37652 relevant lines covered (81.83%)

5.51 hits per line