stacklok / toolhive / 30087972278

73%

Build Type

push

github

Committed by web-flow

Commit Message

Add thv skill upgrade: re-resolve pinned skills to newer content (#5896)

* Add thv skill upgrade: re-resolve pinned skills to newer content

RFC THV-0080 needs a controlled way to pull newer content for
skills pinned by source, without silently drifting the lock file
on every install. This adds the full upgrade vertical slice:
service logic, HTTP endpoint, client, and CLI command.

- Upgrade re-resolves each targeted entry's Source (via the same
  git/OCI/registry dispatch order Install uses, stopping short of
  extraction — resolveLatestState) and installs newer content when
  the digest changed; Source itself is never rewritten
- Entries pinned to an immutable reference (an OCI digest or full
  git commit hash) report not-upgradable — there's nothing newer to
  resolve to
- --preview reports what would change without persisting it;
  --allow-ref-change permits the resolved reference itself
  changing; --fail-on-changes gives CI a freshness gate
- var _ skills.SkillLockService = (*service)(nil) lands here now
  that both Sync and Upgrade exist; SkillsRouter widens from the
  narrow skillSyncer interface (PR4) to the full interface
- `thv skill upgrade [name...]` CLI

Part of the production stack for #5715 (RFC THV-0080). Stack: 5/6.

* Make --fail-on-changes a true no-mutate CI gate

Upgrade installed each target in sequence and only checked
FailOnChanges after each one returned, so a multi-skill upgrade
would install the first changed skill for real before reporting the
conflict — a partial mutation a read-only CI gate must never
produce. Split into a resolve-only planning pass (also reused to
avoid re-resolving Source a second time when applying) and an apply
pass that only runs once every target has been checked. Upgrade also
now preserves a skill's existing clients instead of expanding to
every detected client, matching Sync's behavior.

* Fix broken OCI upgrade path and make fail-on-changes report-only

Two panel-review majors left the OCI upgr... (continued)

Coverage Stats

168 of 278 new or added lines in 6 files covered. (60.43%)

4 existing lines in 2 files now uncovered.

78466 of 113352 relevant lines covered (69.22%)

80.42 hits per line