source-academy / py-slang / 30087195502

86%

push

github

Fix py2js: module-invoked Python callback couldn't call another asyncOnly module function (#350)

pyClosureFunc's fallback body (used whenever the closure_call_sync fast
path can't handle the call) ran the callback via rt.callSync, which
always executes its sync compiled body regardless of how the module
invoked it. That meant a module-invoked Python callback could never
await anything, so a nested call to another asyncOnly module function
(e.g. a stacking_adsr envelope lambda calling adsr()) threw "needs a
frontend round-trip" unconditionally.

Since this fallback body is an async generator already paying a
microtask per call (the .sync fast path exists precisely to skip that
tax for provably scalar-only closures), switching it to rt.acall costs
nothing extra in the common case and lets nested asyncOnly calls
actually suspend.

Fixes source-academy/py-slang#348.


Claude-Session: https://claude.ai/code/session_01KrwJGug3rCXijRseRjys9V

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

4405 of 5504 branches covered (80.03%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

9544 of 10690 relevant lines covered (89.28%)

178377.02 hits per line